Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust 1.46 now allows more features in const fn #883

Merged
merged 3 commits into from
Sep 10, 2020
Merged

Rust 1.46 now allows more features in const fn #883

merged 3 commits into from
Sep 10, 2020

Conversation

jrincayc
Copy link
Contributor

@jrincayc jrincayc commented Sep 4, 2020

These have been added in rust-lang/rust#72437 so should be added to the reference.

@ehuss
Copy link
Contributor

ehuss commented Sep 4, 2020

Thanks, I've actually been meaning to delete this entire section. Would you mind doing that, and linking to the const-eval chapter (https://github.com/rust-lang/reference/blob/master/src/const_eval.md#const-functions)? It might also be good to double check that the const-eval chapter is not missing anything here (it has been recently updated).

@jrincayc
Copy link
Contributor Author

jrincayc commented Sep 7, 2020

Thanks, I've actually been meaning to delete this entire section. Would you mind doing that, and linking to the const-eval chapter (https://github.com/rust-lang/reference/blob/master/src/const_eval.md#const-functions)? It might also be good to double check that the const-eval chapter is not missing anything here (it has been recently updated).

I deleted most of the section in the newest merge version and moved things that I thought useful to the const_eval.md. I left a link to the const-functions section.

@ehuss
Copy link
Contributor

ehuss commented Sep 9, 2020

Thanks! Just one minor thing, this leaves some dangling link references at the bottom of src/items/functions.md, can you remove them? I think they are:

  • [trait bounds]
  • [`?Sized`]
  • [external_block_abi] (unrelated to this PR, but can also be removed)

@jrincayc
Copy link
Contributor Author

Thanks! Just one minor thing, this leaves some dangling link references at the bottom of src/items/functions.md, can you remove them? I think they are:

* `[trait bounds]`

* `` [`?Sized`] ``

* `[external_block_abi]` (unrelated to this PR, but can also be removed)

I removed those references.
P.S. is there some trick to finding them?

ehuss
ehuss approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit 05ddf66 into rust-lang:master Sep 10, 2020
@ehuss
Copy link
Contributor

ehuss commented Sep 10, 2020

P.S. is there some trick to finding them?

Not really, just check when removing a link if there are any other references. Unfortunately the markdown parser eats the references and doesn't provide a way to access them.

@jrincayc jrincayc deleted the const_fn_additions branch September 10, 2020 01:34
@ehuss ehuss mentioned this pull request Sep 15, 2020
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#76764 - ehuss:update-books, r=ehuss
f868f02 
Update books

## nomicon

1 commits in 25854752549d44d76fbd7650e17cb4f167a0b8fb..6e57e64501f61873ab80cb78a07180a22751a5d6
2020-08-19 16:41:48 -0400 to 2020-09-14 11:40:23 -0400
- Fix API change to alloc::Global::grow. (rust-lang/nomicon#236)

## reference

3 commits in 25391dba46262f882fa846beefaff54a966a8fa5..56a13c082ee90736c08d6abdcd90462517b703d3
2020-09-02 07:22:55 -0700 to 2020-09-14 23:20:16 -0700
- Update the description of staticlib (rust-lang/reference#884)
- Rust 1.46 now allows more features in const fn (rust-lang/reference#883)
- Document the enum changes in RFC 2195 (rust-lang/reference#879)

## book

1 commits in e5ed97128302d5fa45dbac0e64426bc7649a558c..cb28dee95e5e50b793e6ba9291c5d1568d3ad72e
2020-08-31 12:53:40 -0500 to 2020-09-09 10:06:00 -0500
- Fixed the error message of invalid array element access in ch03.2 (rust-lang/book#2446)
tmandry added a commit to tmandry/rust that referenced this pull request Sep 16, 2020
@tmandry
Rollup merge of rust-lang#76764 - ehuss:update-books, r=ehuss
5d8bc90 
Update books

## nomicon

1 commits in 25854752549d44d76fbd7650e17cb4f167a0b8fb..6e57e64501f61873ab80cb78a07180a22751a5d6
2020-08-19 16:41:48 -0400 to 2020-09-14 11:40:23 -0400
- Fix API change to alloc::Global::grow. (rust-lang/nomicon#236)

## reference

3 commits in 25391dba46262f882fa846beefaff54a966a8fa5..56a13c082ee90736c08d6abdcd90462517b703d3
2020-09-02 07:22:55 -0700 to 2020-09-14 23:20:16 -0700
- Update the description of staticlib (rust-lang/reference#884)
- Rust 1.46 now allows more features in const fn (rust-lang/reference#883)
- Document the enum changes in RFC 2195 (rust-lang/reference#879)

## book

1 commits in e5ed97128302d5fa45dbac0e64426bc7649a558c..cb28dee95e5e50b793e6ba9291c5d1568d3ad72e
2020-08-31 12:53:40 -0500 to 2020-09-09 10:06:00 -0500
- Fixed the error message of invalid array element access in ch03.2 (rust-lang/book#2446)
@ehuss ehuss mentioned this pull request Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehuss ehuss ehuss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrincayc @ehuss